Skip to content

time 2.0: stepable, non monotonic, #21532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mockersf wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

time 2.0: stepable, non monotonic, #21532

mockersf wants to merge 12 commits into from

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Oct 13, 2025 •
edited
Loading

Objective

  • Time falls a bit short of some scenarios:
    • It's backed by a Duration, it can be hard to use as a number of steps since beginning
    • It's monotonic, so travelling backward in time for replay is not possible

Solution

  • Make Time generic over the type used to back the impl
  • Add new contexts that can travel back in time

@mockersf mockersf added the A-Time Involves time keeping and reporting label Oct 13, 2025
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 14, 2025
alice-i-cecile
alice-i-cecile reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly in favor of this design, and the feature itself. This would be useful for simulation. Needs more docs, examples and a quick release note before I can approve or give a full review though.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees

No one assigned

Labels

A-Time Involves time keeping and reporting C-Feature A new feature, making something new possible M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mockersf @alice-i-cecile